[flashrom] [PATCH] Refactor ITE SuperI/O detection/access

Luc Verhaegen libv at skynet.be
Tue Dec 8 11:52:08 CET 2009

On Mon, Nov 16, 2009 at 02:16:08AM +0100, Carl-Daniel Hailfinger wrote:
> Refactor ITE SuperI/O detection/access.
> The new code reduces duplications and paves the way for generic SuperI/O
> detection.
> Additional cost: We enter/exit the SuperI/O configuration mode twice.
> Once for detecting which SuperI/O it is, and once for actually changing
> the settings.
> Additional benefit: This has the potential of allowing some sort of
> primitive laptop detection (by way of checking whether an EC or a simple
> SuperI/O is present).
> I have added a call to a not yet implemented Winbond SuperI/O detection
> function inside #if 0 to make extension more straighforward.
> This affects most SiS chipsets and IT87 SPI translation, so tests in
> verbose mode would be appreciated. In theory, functionality should be
> unchanged.
> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>


The code in the chipset enable needs to go :)

Apart from that, we need this, we need general superio detection, and 
the write enables moved out of board_enable.c, plus some gpio line 
setting code per superio.

For the IT8705, we need to work out what we want to do, there are two 
similar routines in board_enable.c, and this code below is the third.

We need a single one, and for the time being, it needs to be done
depending on a board match.

Also, do we need the ite spi probe before we do flash detection?

So toss out the superio from the chipset enable (patch filed), and then 
alter the patch here to provide us with more general superio 
infrastructure :)

We need this.

Luc Verhaegen.

More information about the flashrom mailing list