Looks fine to me! the printf_debug doesn't seem correct, should it be: printf_debug("0x%06x-0x%06x, ", start, start+len) ? Acked-by: Sean Nelson <audiohacked at gmail.com>