[flashrom] [PATCH] Improve error messages, protect the user

Stefan Reinauer stepan at coresystems.de
Wed Aug 19 14:03:17 CEST 2009


On 8/12/09 2:06 PM, Carl-Daniel Hailfinger wrote:

> +	if (verify_it) {
> +		/* Work around chips which need some time to calm down. */
> +		if (write_it)
> +			programmer_delay(1000*1000);
>  		ret = verify_flash(flash, buf);
> +		if (ret)
> +			emergency_help_message();
> +	}
>   
This should be

/* If we tried to write, and now we don't properly verify, we might have
an emergency situation */
if (write_it && ret)
    emergency_help_message();

Otherwise

Acked-by: Stefan Reinauer <stepan at coresystems.de>

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info at coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866





More information about the flashrom mailing list