[flashrom] [PATCH] Use correct programmer fallback functions

[Carl-Daniel Hailfinger]

On 12.08.2009 11:29, Stefan Reinauer wrote:
> On 8/11/09 3:12 AM, Carl-Daniel Hailfinger wrote:
>   
>> FT2232 and IT87 programmers used functions of the dummy programmer
>> instead of fallback functions. The dummy programmer is a "real"
>> programmer with possible side effects and its functions should not be
>> abused by other programmers. Make FT2232 and IT87 use official fallback
>> functions instead.
>> Create fallback_shutdown().
>> Create fallback_chip_writeb().
>> Convert the programmer #defines to an enum.
>>
>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>  
>>     
>
> We should drop the dummy programmer then... It's good for nothing
>   

It's essential for four reasons:
- Testing code flow as normal user without hardware for verification.
- Nondestructive experiments with flashrom.
- Machine and human readable flash access log, helped me find all those
finctions which copy probe_jedec instead of calling it, and it also
helped me find the incorrect programming sequence for 82802AB.
- Template to base new driver code on.

All the four use cases above were already seen in practice, and I'm not
the only one using them.

> Acked-by: Stefan Reinauer <stepan at coresystems.de>
>   

Thanks, r678.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/