[flashrom] [PATCH] fix MSR code in flashrom

Carl-Daniel Hailfinger c-d.hailfinger.devel.2006 at gmx.net
Tue Aug 11 16:01:39 CEST 2009


On 11.08.2009 15:59, Stefan Reinauer wrote:
> On 8/11/09 3:43 PM, Carl-Daniel Hailfinger wrote:
>   
>> On 11.08.2009 15:00, Stefan Reinauer wrote:
>>   
>>     
>>> See patch... With this flashrom won't try to open /dev/cpu/x/msr on
>>> non-linux OSes...
>>>
>>> Fix up MSR handling in flashrom to support more OSes than Linux. 
>>>
>>> Signed-off-by: Stefan Reinauer <stepan at coresystems.de>
>>>     
>>>       
>> I'm not totally happy with the abstraction and think getting MSR access
>> should be part of getting IO permissions, but this is a good step forward.
>>
>>     
> I considered that. BUT: Why make code run every time, if it's only
> needed on 1% or less of the machines.
>   

True. Go ahead.

Regards,
Carl-Daniel

-- 
http://www.hailfinger.org/





More information about the flashrom mailing list