[coreboot] Who is still using a 1980's tty for coreboot development?

Patrick Georgi pgeorgi at google.com
Fri May 25 17:24:01 CEST 2018


Am Fr., 25. Mai 2018 um 17:05 Uhr schrieb Vadim Bendebury <
vbendeb at chromium.org>:
> limiting width to 80 columns helps greatly when one wants to see several
screens side by side.

$ echo $COLUMNS
274

Two terminals of 120 + metadata (linenumbers, window frames, ...) fit well,
and that's just a plain old Full HD display.
I heard 4K is all the rage now ;-)

> And of course implicitly keeps the code cleaner - if so much indentation
is needed, the code is likely ripe for refactoring.
Several of our function signatures are longer than a line.

Two levels of indentation (function level + if clause), plus
'printk(BIOS_ERROR, "\n");' is already more than half an 80 column screen.
Breaking up messages means that they're harder to find with a git grep.


Regards,
Patrick
-- 
Google Germany GmbH, ABC-Str. 19, 20354 Hamburg
Registergericht und -nummer: Hamburg, HRB 86891, Sitz der Gesellschaft:
Hamburg
Geschäftsführer: Paul Manicle, Halimah DeLaine Prado



More information about the coreboot mailing list