[coreboot] Exception on Skylake after enabling ACPI timer emulation

[Banik, Subrata]

Can you please check few more things and please help to clarify some details.

1. Is this kind of regression ? because we are not seeing this issue.
2. I believe its FSP1.1 selection in Kconfig, please confirm ?
3. Please check if BIOS_RESET_CPL is already set prior to setting 0x121 MSR
	Refer to code enable_bios_reset_cpl
As per my debug MSR 0x121 will only through exception if BIOS reset cpl done bits are already set before this call, which shouldn't be the case, otherwise all SKL design might see this issue. 
	

Thanks,
Subrata


-----Original Message-----
From: Piotr Król [mailto:piotr.krol at 3mdeb.com] 
Sent: Thursday, May 17, 2018 7:09 PM
To: Banik, Subrata <subrata.banik at intel.com>
Cc: coreboot at coreboot.org
Subject: Re: Exception on Skylake after enabling ACPI timer emulation

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256



On 05/17/2018 02:11 PM, Banik, Subrata wrote:

Subrata,

> 
> [Subrata] this specific issue, we haven't seen on any KBL/SKL system 
> we have. I can double confirm this value tomorrow. For now, please try 
> to check if increasing timeout is helping or not?

Values tried:
- - vmx: 2x, sgx: 28x: https://pastebin.com/imRJk7Y8
- - vmx: 4x, sgx: 14x: https://pastebin.com/Rwvcs4XE
- - vmx: 8x, sgx: 14x: https://pastebin.com/TLavR6CN
- - vmx: 2x, sgx: 28x: https://pastebin.com/SdbP0RdG
- - vmx: 32x, sgx: 56x: https://pastebin.com/NsK25Lm5

Not much chageing. Mostly timing of SIPI completion and order of SMRAM relocation.


> Btw, Can you please send me a complete serial log for my analysis.
> 
Sure:
- - my code base: https://pastebin.com/fRFZTx10
- - with 26286/3: https://pastebin.com/S1n5S8df

I believe this should not be relevant, but I don't have serial enabled and all logs are dumped to SPI. I'm not sure if SPI controller interrupts may affect this anyhow.

Best Regards,
- --
Piotr Król
Embedded Systems Consultant
https://3mdeb.com | @3mdeb_com
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE4DCbLYWmfoRjKeNLsu5x6WeqnkwFAlr9hfwACgkQsu5x6Weq
nkyR0Q//dezp7DKk41bSIQIEn4VIMBNwiCI/g5ZJ6JbOHZnfiaDDaVmbLB59Ef0H
jNu4nRFV157WRGlXv2B0lq2/S3XfQfJJsjUfZiG3ZSB4zAzAZENaCI01hjFgjlx8
LrY1t3GLMmRwXbVABJfTUOWcOFNcC38kK0XeLMnTWCpLuXWS8lmbqPbuyH8nc64v
A/K8oqjQlTKMq82Rpch7H94nlcQN/CgWHcjoTfSbU7IAnXmO4J34DUhEDKaOOqX3
xVQg+lVA3qEeMotOtxMXfji9ROss9D72+R9/2kIWCM7GkTrwIcmghFCH7xDPNHxX
P6zymsS93JfM9LC02zDMpD7Fp/TTMamr4jznIQ2tvckWtJE7Bh+Ska3411mpRqcP
qhHfnlIYgJC7zKVi+sPx2WMRcf504033RuhHg9ajtsaPLVGDWtoVFPqQ1llPFp+y
IRTzgMPFrwrOM1QmPntbWxy5Sx1MGfrx0y8Pt03iHRcmj8e3O1aMatavAPhD136W
T9d9nO/wDBAk97V6xpq6uXWonCtUHjflGh+TZICjkDSlJj3cAGC5cIg8DMPDoHEF
cZaMmEhHd+4ceMvCkevlYm1yrcFdaVuGMT9p7Ejb4r9y0d1/AcGdi61wjxnc80eB
yVUOkzqHM1oQk6mYdUXOVU+CXl3LiXIMpTW26dEDexOg40UcttI=
=F1Se
-----END PGP SIGNATURE-----