[coreboot] New Defects reported by Coverity Scan for coreboot

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

2 new defect(s) introduced to coreboot found with Coverity Scan.
19 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1391422:  Incorrect expression  (CONSTANT_EXPRESSION_RESULT)
/src/soc/intel/broadwell/romstage/raminit.c: 128 in raminit()


________________________________________________________________________________________________________
*** CID 1391422:  Incorrect expression  (CONSTANT_EXPRESSION_RESULT)
/src/soc/intel/broadwell/romstage/raminit.c: 128 in raminit()
122     
123     	printk(BIOS_DEBUG, "create cbmem for dimm information\n");
124     	mem_info = cbmem_add(CBMEM_ID_MEMINFO, sizeof(struct memory_info));
125     	memset(mem_info, 0, sizeof(*mem_info));
126     	/* Translate pei_memory_info struct data into memory_info struct */
127     	mem_info->dimm_cnt = pei_data->meminfo.dimm_cnt;
>>>     CID 1391422:  Incorrect expression  (CONSTANT_EXPRESSION_RESULT)
>>>     "8 < 8" is always false regardless of the values of its operands because those operands are identical. This occurs as the logical first operand of "?:".
128     	for (int i = 0; i < MIN(DIMM_INFO_TOTAL, PEI_DIMM_INFO_TOTAL); i++) {
129     		struct dimm_info *dimm = &mem_info->dimm[i];
130     		const struct pei_dimm_info *pei_dimm =
131     			&pei_data->meminfo.dimm[i];
132     		dimm->dimm_size = pei_dimm->dimm_size;
133     		dimm->ddr_type = pei_dimm->ddr_type;

** CID 1271711:  Control flow issues  (DEADCODE)
/src/include/device/hypertransport_def.h: 26 in offset_unit_id()


________________________________________________________________________________________________________
*** CID 1271711:  Control flow issues  (DEADCODE)
/src/include/device/hypertransport_def.h: 26 in offset_unit_id()
20     
21     
22     static inline bool offset_unit_id(bool is_sb_ht_chain)
23     {
24     	bool need_offset = (CONFIG_HT_CHAIN_UNITID_BASE != 1)
25     		|| (CONFIG_HT_CHAIN_END_UNITID_BASE != 0x20);
>>>     CID 1271711:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "1" inside this statement: "return need_offset && (1 ||...".
26     	return need_offset && (!CONFIG_SB_HT_CHAIN_UNITID_OFFSET_ONLY
27     		|| is_sb_ht_chain);
28     }
29     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5Y8cuFDnekytryaA1w2AudMZXFdr0r5W6YqcrybZXP-2FdO7RQt0L90gPq4GDL1hLmmQMrQiGt3qP3jM0NRBgB6m6p63cnEUc2mBSq2-2BhJ6e1PC6t-2F7zSqU8dKnPu7OM25NNFzedyN6XJ7e0dykECy6qZxGy0HR4yo-2Fyy0pqKAfpTD35R6Aa2rXNTmXvOHc0kdCk-3D