[coreboot] New Defects reported by Coverity Scan for coreboot

scan-admin at coverity.com scan-admin at coverity.com
Tue Jul 17 16:18:02 CEST 2018


Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

1 new defect(s) introduced to coreboot found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1394268:  Possible Control flow issues  (DEADCODE)
/src/vendorcode/cavium/bdk/libdram/libdram.c: 187 in bdk_libdram_tune_node()


________________________________________________________________________________________________________
*** CID 1394268:  Possible Control flow issues  (DEADCODE)
/src/vendorcode/cavium/bdk/libdram/libdram.c: 187 in bdk_libdram_tune_node()
181         }
182     
183         // disabled by default for now, does not seem to be needed much?
184         // Automatically tune the ECC byte DLL read offsets
185         // FIXME? allow override of the filtering
186         // FIXME? allow programmatic override, not via envvar? 
>>>     CID 1394268:  Possible Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "lmc_config.s.mode32b == 0" inside this statement: "if (do_eccdll && !do_dllro_...".
187         if (do_eccdll && !do_dllro_hw && (lmc_config.s.mode32b == 0)) { // do not do HW-assist twice for ECC
188             BDK_TRACE(DRAM, "N%d: Starting ECC DLL Read Offset Tuning for LMCs\n", node);
189             errs = perform_HW_dll_offset_tuning(node, 2, 8/* ECC bytelane */); 
190             BDK_TRACE(DRAM, "N%d: Finished ECC DLL Read Offset Tuning for LMCs, %d errors\n",
191                       node, errs);
192             tot_errs += errs;


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5ZAnh1-2BndVxV7w7soD42DMTlzJB7wwKyhUkSWrGpkJVeKCNOu7hmR2BjKScIwgOtcFBkq01uD7Xd0N2j70KEKQ7FsCCaEGIDClM8Qd9yGpS6eQLVBZnShwz0f0aEtfgAhsaRckn-2FGK-2F-2Fm-2FnS20Njw-2F82ZkJ02KwDCFMvGYRZcoPvcrLFrrICc0O65vWbLozCZw-3D




More information about the coreboot mailing list