[coreboot] New Defects reported by Coverity Scan for coreboot

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

2 new defect(s) introduced to coreboot found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1385944:  Null pointer dereferences  (NULL_RETURNS)


________________________________________________________________________________________________________
*** CID 1385944:  Null pointer dereferences  (NULL_RETURNS)
/src/drivers/generic/adau7002/adau7002.c: 36 in adau7002_fill_ssdt()
30     static void adau7002_fill_ssdt(struct device *dev)
31     {
32     	if (!dev->enabled)
33     		return;
34     
35     	/* Device */
>>>     CID 1385944:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be null "acpi_device_scope(dev)" when calling "acpigen_write_scope".
36     	acpigen_write_scope(acpi_device_scope(dev));
37     	acpigen_write_device(acpi_device_name(dev));
38     	acpigen_write_name_string("_HID", ADAU7002_ACPI_HID);
39     	acpigen_write_name_integer("_UID", 0);
40     	acpigen_write_name_string("_DDN", dev->chip_ops->name);
41     	acpigen_write_STA(ACPI_STATUS_DEVICE_ALL_ON);

** CID 1385943:  Error handling issues  (CHECKED_RETURN)
/src/soc/amd/common/block/s3/s3_resume.c: 30 in get_s3nv_info()


________________________________________________________________________________________________________
*** CID 1385943:  Error handling issues  (CHECKED_RETURN)
/src/soc/amd/common/block/s3/s3_resume.c: 30 in get_s3nv_info()
24     #define DEFAULT_MRC_VERSION 0
25     
26     void get_s3nv_info(void **base, size_t *size)
27     {
28     	struct region_device rdev;
29     
>>>     CID 1385943:  Error handling issues  (CHECKED_RETURN)
>>>     Calling "mrc_cache_get_current" without checking return value (as is done elsewhere 6 out of 7 times).
30     	mrc_cache_get_current(MRC_TRAINING_DATA, DEFAULT_MRC_VERSION, &rdev);
31     	*base = rdev_mmap_full(&rdev);
32     	*size = region_device_sz(&rdev);
33     	if (!*base || !*size)
34     		printk(BIOS_ERR, "Error: S3 NV data not found\n");
35     	else


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5as2qtTD-2BnoixG71pS-2FVfGTkZkMmiFMbKzAzAYLYNWUQeAj52qoGMxBF4O-2BR8Kt-2F-2F5cIBYgw9JJtBVKPZL9xQSstzwk2CTW2QvuTgz0bhqIQIxtTyZeZ9eyeGeUCr8YwJwTl8ItqSaKQd9llo19F9yOmIXyChyw4W4Wj55anXSAtwO46jUtJdfcRnniN1Dcal0-3D