[coreboot] [RFH] Status of the Lenovo X201

Kyösti Mälkki kyosti.malkki at gmail.com
Thu Apr 26 19:21:33 CEST 2018


On Wed, Apr 25, 2018 at 1:51 PM, Nicola Corna <nicola at corna.info> wrote:
> April 18, 2018 3:54 PM, "Kyösti Mälkki" <kyosti.malkki at gmail.com> wrote:
>
>> Having romstage stack smashed seems irrelevant for the no-boot issue.
>> That nehalem raminit code, struct raminfo, seems to eat a lot of stack
>> and an error message for that case was added with commit 2c3fd49. You
>> could try parent of that commit, but rumour is lenovo/x201 was a
>> no-boot case long time before that.
>
> I'll do some tests to find which commit caused the no-boot.

Well, smashed stack in romstage -error is no longer in the log,
possibly because this boot used MRC cache now.

>
>> I can see int15h messages interleaved with SMP init, that looks odd to
>> me. Also, did the log really end inside 0:1f.0 PCI finalize or was
>> usbdebug logging just interrupted for some reason at that point?
>
> The log really ends there.
>

With config PARALLEL_CPU_INIT=y so SMP / SMM init in initialize_cpus()
will never call wait_other_cpus() at all. That actually regressed in
my commit 0cc2ce4 [1] but I can't test if reverting it solves this for
you. I'll push a regression fix soonish for review.

[1] https://review.coreboot.org/c/coreboot/+/21088


Kyösti



More information about the coreboot mailing list