[coreboot] [PATCH] nb/intel/nehalem/raminit.c: Add timeouts when waiting for heci.

[Timothy Pearson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/27/2017 04:29 PM, Peter Stuge wrote:
> Timothy Pearson wrote:
>> In general static timeouts are not a good idea.
> 
> In general infinite loops are a worse idea.

Agreed.  That being said, this sort of "quick fix" with timeouts is one
way that projects end up adding unneeded boot delay that sticks around
and becomes harder to fix as the years go by.  I've even seen this in
Linux desktop environments; the "fastest" fix to multi-process startup
is often to add a delay to force process start order.  It's almost never
the correct solution, but can serve as a useful backup if something goes
wrong.

>> can it parse the ME descriptor and not even search for the HECI
>> interface if the ME size is less than a certain value?
> 
> That's a good idea! But put the timeout in to begin with.
> 
> 
> //Peter
> 


- -- 
Timothy Pearson
Raptor Engineering
+1 (415) 727-8645 (direct line)
+1 (512) 690-0200 (switchboard)
https://www.raptorengineering.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJY2YW+AAoJEK+E3vEXDOFbM+wIALbhqXc7O30cFJyH1ExSKyGm
/D2Zb9vjDYKferycdI1yCnTd4dQrbtvJJHqI/qGXx/UcgW2VQjN+xx23gGY/Rn6E
IzWlZEJ5BI15cQ5CpSXoRxYT2NFr7fzSbxjEFvUNk6s7YJDpDFr4u/gSJhwRe6vP
hkqhlkO8PqDnIYCqdUvSbAuAsJKJhDNMeCPAA8rL94KASfpH1yYbn1MzqDlhR6qM
Dnm2sDhjUHzFcQCze6Bz9HlAT0up3FrDxcW2tflazo19Tm65KAnGcakalvTY1m7W
9kFdP0RBCoeiNF8eMCUd0hXsMFHQQsSnFbwVIdLIO51Q/f1XR9WSkI0KBQUysBk=
=LWG0
-----END PGP SIGNATURE-----