[coreboot] New Defects reported by Coverity Scan for coreboot

scan-admin at coverity.com scan-admin at coverity.com
Tue Jun 20 14:26:36 CEST 2017


Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

2 new defect(s) introduced to coreboot found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)


** CID 1376385:  Memory - illegal accesses  (RETURN_LOCAL)
/src/arch/x86/smbios.c: 122 in smbios_processor_name()


________________________________________________________________________________________________________
*** CID 1376385:  Memory - illegal accesses  (RETURN_LOCAL)
/src/arch/x86/smbios.c: 122 in smbios_processor_name()
116     				tmp[j++] = res.edx;
117     			}
118     			tmp[12] = 0;
119     			str = (const char *)tmp;
120     		}
121     	}
>>>     CID 1376385:  Memory - illegal accesses  (RETURN_LOCAL)
>>>     Using "str", which points to an out-of-scope variable "tmp".
122     	return smbios_add_string(start, str);
123     }
124     
125     /* this function will fill the corresponding manufacturer */
126     void smbios_fill_dimm_manufacturer_from_id(uint16_t mod_id,
127     	struct smbios_type17 *t)

** CID 1376384:  Null pointer dereferences  (NULL_RETURNS)
/src/northbridge/intel/haswell/raminit.c: 190 in setup_sdram_meminfo()


________________________________________________________________________________________________________
*** CID 1376384:  Null pointer dereferences  (NULL_RETURNS)
/src/northbridge/intel/haswell/raminit.c: 190 in setup_sdram_meminfo()
184     	int ddr_frequency;
185     	int dimm_size;
186     	int ch, d_num;
187     	int dimm_cnt = 0;
188     
189     	mem_info = cbmem_add(CBMEM_ID_MEMINFO, sizeof(struct memory_info));
>>>     CID 1376384:  Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be null "mem_info" when calling "memset". [Note: The source code implementation of the function has been overridden by a builtin model.]
190     	memset(mem_info, 0, sizeof(struct memory_info));
191     
192     	addr_decoder_common = MCHBAR32(0x5000);
193     	addr_decode_ch[0] = MCHBAR32(0x5004);
194     	addr_decode_ch[1] = MCHBAR32(0x5008);
195     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bfQWv4ukkltKGHUOMMcqepqA6nOwrKunEixAgRpMmUHPJUZoAlM35Rmb7CKjfqK35-2F5kDobSUbZXRVZLmugJAysy-2FduW-2FhjKqx68sX12oyL7kBV-2BDjAgRVufTOrvRpu68pznflw363uyYQRHceB69IxDVb1a4hGgU1nlQcU9BN-2BvKHNZmIyoIS5-2BuD3YY-2FVp4-3D

To manage Coverity Scan email notifications for "coreboot at coreboot.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4e-2BpBzwOa5gzBZa9dWpDbzfofODnVj1enK2UkK0-2BgCCqyeem8IVKvTxSaOFkteZFcnohwvb2rnYNjswGryEWCURnUk6WHU42sbOmtOjD-2Bx5c-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bfQWv4ukkltKGHUOMMcqepsfOI-2BILuA5MWwIPEpmQQoCyyXKZymD-2F7X-2FERNNQuuGfzzpCZcGv6wtLWv2WaK-2Bm43ffViKYrP1B-2B3ANHY6yJsq1hBard8V4cRW7fHny6FCpbnX2CXH6ty-2BtFinzlyNAB6xyHkjp6iStIRGgUOEb2Rbea0wJonlr9EhrwsJxoKJs-3D




More information about the coreboot mailing list