[coreboot] Dont filter supported CPUs on a mainboard by the CPUID

Aaron Durbin adurbin at google.com
Thu Feb 23 15:31:23 CET 2017


On Thu, Feb 23, 2017 at 2:39 AM, Nico Huber <nico.h at gmx.de> wrote:
> On 23.02.2017 00:07, i1w5d7gf38keg at tutanota.com wrote:
>
>> There is a Filter to stop booting when the CPUID is not in a list of
>> supported CPUs. This filter does not make sense in the real world usage.
>
> It's not a filter. It's a measure to know which code to run for which
> CPU. Please dig a little deeper before making such useless complaints.

To add to Nico's point: the cpuid list is a way to bind code code to
run for certain devices -- including CPUs. If the cpuid is not listed
then the match on device->code to run is not met. Therefore, the code
necessary to make that CPU work won't ever be ran. src/arch/x86/cpu.c
has the cpu driver binding. And there already is message printed. See
the callers of set_cpu_ops() in that file. The issue is that we die()
when no match is found. We could attempt to boot further, but there's
no guarantee it'd actually succeed.

>
> Nico
>
> --
> coreboot mailing list: coreboot at coreboot.org
> https://www.coreboot.org/mailman/listinfo/coreboot



More information about the coreboot mailing list