[coreboot] ThinkPad X201 compile error

Nico Huber nico.h at gmx.de
Mon Dec 18 12:14:26 CET 2017


On 18.12.2017 11:44, Federico Amedeo Izzo wrote:
> Hello,
> 
> I wanted to update coreboot on my X201 from the Feb 2017 source
> (commit 068edc1c52cb1e5b6376ba7f296ef8797a24cd5f)
> to current master
> (commit f2e7b37c52cac5e7825d0e01b3c45c1506e99253)
> But when compiling it gives the following error
> ```
> src/northbridge/intel/nehalem/gma.c: In function 'gma_func0_init':
> src/northbridge/intel/nehalem/gma.c:1066:5: error: implicit declaration
> of function 'intel_gma_init' [-Werror=implicit-function-declaration]
>      intel_gma_init(conf, res2mmio(gtt_res, 0, 0),```

Wooops, my fault! Fix here:
  https://review.coreboot.org/#/c/coreboot/+/22930

You just need to remove the #if and #endif in lines 575 and 1012,
respectively.

> 
> Now it's configured to load a VGA blob, if I enable "native graphics
> init" instead, the compile error goes away, but the resulting image does
> not boot (beep and flashing leds)

I fear this error is not gfx related. The Nehalem code isn't widely tes-
ted, I suggest trying again with different DIMMS / DIMM combinations.

Hope that helps,
Nico



More information about the coreboot mailing list