[coreboot] Asus P2-99: PS2 keyboard, time stamps, double logs

[Keith Hui]

Paul,

I also have similar keyboard troubles with my P2B-LS, when I would not
be able to use the keyboard to select an entry to boot at LILO prompt.
Setting a PS/2 keyboard timeout and/or init in both coreboot and
SeaBIOS seems to help, but not sure if it helps 100%.

And how do I set up board variants? At this point we should be able to
group the Asus P2B family into 4 boards plus variants:

P2B+P2-99 (3 DIMM, served by asus/p2b)
P2B-F+P2B-L/S/LS (4 DIMM, served by asus/p2b-ls, the "L"AN works fine
without any work from coreboot; while I still haven't figured out
terminations of the onboard Adaptec "S"CSI device)
P3B-F (4 DIMM, served by asus/p3b-f, it needs extra code to enable SPD)
P2B-D+P2B-DS (4 DIMM, SMP, served by asus/p2b-ds)

> From: Paul Menzel <paulepanter at users.sourceforge.net>
> To: Branden Waldner <scruffy99 at gmail.com>
> Cc: coreboot at coreboot.org
> Bcc:
> Date: Sat, 16 Dec 2017 11:08:22 +0100
> Subject: [coreboot] Asus P2-99: PS2 keyboard, time stamps, double logs
> Dear Branden,
>
>
> Thank you for uploading the results for your ASUS P2-99 to the board
> status repository [1].
>
> You configured your board as below.
>
> ```
> # This image was built using coreboot 4.6-2379-g0cc28d7e61
> CONFIG_VENDOR_ASUS=y
> CONFIG_BOARD_ASUS_P2B=y
> CONFIG_DRIVERS_PS2_KEYBOARD=y
> CONFIG_SEABIOS_PS2_TIMEOUT=500
> # CONFIG_DRIVERS_INTEL_WIFI is not set
> CONFIG_MAINBOARD_SMBIOS_PRODUCT_NAME="P2-99"
> CONFIG_SEABIOS_MASTER=y
> ```
>
> First, if the image built for the different board Asus P2B builds, we
> should just add a variant for the Asus P2-99, so that the upload is not
> so confusing.
>
> Second, as you use SeaBIOS as a payload you can deselect
> `CONFIG_DRIVERS_PS2_KEYBOARD` as SeaBIOS can initialize that on its
> own.
>
> I only know the time-out for SeaBIOS to be needed on laptops. Is
> SeaBIOS unable to initialize the PS/2 keyboard, when you remove the
> time-out?
>
> Despite time stamp collection being enabled
> (`CONFIG_COLLECT_TIMESTAMPS=y`), there is no upload of the output
> `cbmem -t`. Is that not working?
>
> Also, did your board reboot/reset in between?
>
> ```
> […]
> SeaBIOS (version rel-1.11.0-4-g844b864)
> […]
> Booting from Hard Disk...
> Booting from 0000:7c00
>
>
> coreboot-4.6-2379-g0cc28d7e61 Fri Dec 15 03:32:04 UTC 2017 romstage starting...
> […]
> ```
>
>
> Thanks,
>
> Paul
>
>
> [1] asus/p2b/4.6-2379-g0cc28d7e61/2017-12-15T03_32_04Z