[coreboot] New Defects reported by Coverity Scan for coreboot

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

3 new defect(s) introduced to coreboot found with Coverity Scan.
3 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1379849:  Null pointer dereferences  (FORWARD_NULL)
/src/soc/intel/cannonlake/pmutil.c: 211 in soc_get_gpe_configs()


________________________________________________________________________________________________________
*** CID 1379849:  Null pointer dereferences  (FORWARD_NULL)
/src/soc/intel/cannonlake/pmutil.c: 211 in soc_get_gpe_configs()
205     
206     	/* Look up the device in devicetree */
207     	DEVTREE_CONST struct device *dev = dev_find_slot(0, PCH_DEVFN_PMC);
208     	if (!dev || !dev->chip_info) {
209     		printk(BIOS_ERR, "BUG! Could not find SOC devicetree config\n");
210     	}
>>>     CID 1379849:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "dev".
211     	config = dev->chip_info;
212     
213     	/* Assign to out variable */
214     	*dw0 = config->gpe0_dw0;
215     	*dw1 = config->gpe0_dw1;
216     	*dw2 = config->gpe0_dw2;

** CID 1379848:  Null pointer dereferences  (FORWARD_NULL)
/src/soc/intel/cannonlake/pmutil.c: 214 in soc_get_gpe_configs()


________________________________________________________________________________________________________
*** CID 1379848:  Null pointer dereferences  (FORWARD_NULL)
/src/soc/intel/cannonlake/pmutil.c: 214 in soc_get_gpe_configs()
208     	if (!dev || !dev->chip_info) {
209     		printk(BIOS_ERR, "BUG! Could not find SOC devicetree config\n");
210     	}
211     	config = dev->chip_info;
212     
213     	/* Assign to out variable */
>>>     CID 1379848:  Null pointer dereferences  (FORWARD_NULL)
>>>     Dereferencing null pointer "config".
214     	*dw0 = config->gpe0_dw0;
215     	*dw1 = config->gpe0_dw1;
216     	*dw2 = config->gpe0_dw2;

** CID 1379847:  Control flow issues  (DEADCODE)
/src/cpu/x86/lapic/lapic_cpu_init.c: 529 in wait_other_cpus_stop()


________________________________________________________________________________________________________
*** CID 1379847:  Control flow issues  (DEADCODE)
/src/cpu/x86/lapic/lapic_cpu_init.c: 529 in wait_other_cpus_stop()
523     		if (!cpu->initialized)
524     			printk(BIOS_ERR, "CPU 0x%02x did not initialize!\n",
525     				cpu->path.apic.apic_id);
526     	}
527     	printk(BIOS_DEBUG, "All AP CPUs stopped (%ld loops)\n", loopcount);
528     	checkstack(_estack, 0);
>>>     CID 1379847:  Control flow issues  (DEADCODE)
>>>     Execution cannot reach the expression "i <= last_cpu_index" inside this statement: "for (i = 1; i < 1 && i <= l...".
529     	for (i = 1; i < CONFIG_MAX_CPUS && i <= last_cpu_index; i++)
530     		checkstack((void *)stacks[i] + CONFIG_STACK_SIZE, i);
531     }
532     
533     void initialize_cpus(struct bus *cpu_bus)
534     {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5YHfvzpMuJYF-2BGLa7aL1KZYf20oCvrecqKbCq3j5siQT1IpSscUaf3eMLXr0p6WjZpKgKaJg-2F36bsIGkj-2BCm96NyzyD9t7Q06CN-2F9bt-2BtQm78bfOqKM8NCtQgLUX0HGQXxgGe6-2BQOFCYZIjNcwtCQu2yJvqNQ7y64SjXN-2FVe2FUQ8kkt4iWCPr5DuMgLwluHfE-3D

To manage Coverity Scan email notifications for "coreboot at coreboot.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4e-2BpBzwOa5gzBZa9dWpDbzfofODnVj1enK2UkK0-2BgCCqyeem8IVKvTxSaOFkteZFcnohwvb2rnYNjswGryEWCURnUk6WHU42sbOmtOjD-2Bx5c-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5YHfvzpMuJYF-2BGLa7aL1KZYpRPKNGRkr9haaG4AYd1b34mPQZVetronDQXo-2FUnErdKFAwXLEGzRy-2BN4VS9a1nVZCzsYlvKLKRQTfYONKUViyHFkwdagUgrSF8k3lwS9ZuViEEFAzd57Fz1TODfmYpeKaLitQTNyCMa99XK6Kxt9SJxqvkF8ydcb0lMEzzCDDTI-3D