[coreboot] New Defects reported by Coverity Scan for coreboot

[scan-admin at coverity.com]

Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

1 new defect(s) introduced to coreboot found with Coverity Scan.


New defect(s) Reported-by: Coverity Scan
Showing 1 of 1 defect(s)


** CID 1363355:    (SIZEOF_MISMATCH)
/src/drivers/intel/fsp2_0/upd_display.c: 37 in fspm_display_arch_params()
/src/drivers/intel/fsp2_0/upd_display.c: 40 in fspm_display_arch_params()


________________________________________________________________________________________________________
*** CID 1363355:    (SIZEOF_MISMATCH)
/src/drivers/intel/fsp2_0/upd_display.c: 37 in fspm_display_arch_params()
31     {
32     	/* Display the architectural parameters for MemoryInit */
33     	printk(BIOS_SPEW, "Architectural UPD values for MemoryInit at: 0x%p\n",
34     		new);
35     	fsp_display_upd_value("Revision", sizeof(old->Revision),
36     		old->Revision, new->Revision);
>>>     CID 1363355:    (SIZEOF_MISMATCH)
>>>     Passing argument "old->NvsBufferPtr" of type "void * const" and argument "4UL /* sizeof (old->NvsBufferPtr) */" to function "fsp_display_upd_value" is suspicious.
37     	fsp_display_upd_value("NvsBufferPtr", sizeof(old->NvsBufferPtr),
38     		(uintptr_t)old->NvsBufferPtr,
39     		(uintptr_t)new->NvsBufferPtr);
40     	fsp_display_upd_value("StackBase", sizeof(old->StackBase),
41     		(uintptr_t)old->StackBase,
42     		(uintptr_t)new->StackBase);
/src/drivers/intel/fsp2_0/upd_display.c: 40 in fspm_display_arch_params()
34     		new);
35     	fsp_display_upd_value("Revision", sizeof(old->Revision),
36     		old->Revision, new->Revision);
37     	fsp_display_upd_value("NvsBufferPtr", sizeof(old->NvsBufferPtr),
38     		(uintptr_t)old->NvsBufferPtr,
39     		(uintptr_t)new->NvsBufferPtr);
>>>     CID 1363355:    (SIZEOF_MISMATCH)
>>>     Passing argument "old->StackBase" of type "void * const" and argument "4UL /* sizeof (old->StackBase) */" to function "fsp_display_upd_value" is suspicious.
40     	fsp_display_upd_value("StackBase", sizeof(old->StackBase),
41     		(uintptr_t)old->StackBase,
42     		(uintptr_t)new->StackBase);
43     	fsp_display_upd_value("StackSize", sizeof(old->StackSize),
44     		old->StackSize, new->StackSize);
45     	fsp_display_upd_value("BootLoaderTolumSize",


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvQ-3D-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bttigs8QtwnKKnhkTIL7bVQSAel3CxsulsREKzUQLrTjrXrFHRfVjxo0x5rk0cIQLSOm6x0PWeFb8SRxBlfYPSFVUI7-2BO2gSCZ0LnNi9KbBggTRTtnyZrD-2B9K03yUrSIQMHHDX0KFKS7oJTYZ03ayIjosRWlCy-2Bk6KGQ7zMu0LBg-3D-3D

To manage Coverity Scan email notifications for "coreboot at coreboot.org", click https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4e-2BpBzwOa5gzBZa9dWpDbzfofODnVj1enK2UkK0-2BgCCqyeem8IVKvTxSaOFkteZFcnohwvb2rnYNjswGryEWCURnUk6WHU42sbOmtOjD-2Bx5c-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5bttigs8QtwnKKnhkTIL7bVhKGrtNAuqb3rQKT6xl5AX4sbp4A-2FlPxkxGSPDx-2B14y53aHTJF0bVHS0S1KrBDdJSaL-2BePvKJzOKrHzQ9CEmXJ4bgny9PB84-2Bd3wz38OwbAth0cZHM-2Bi-2B8s18lR88t0c6fsrUDIcrlH5gBBc367YOEw-3D-3D