[coreboot] nvramcui: VGA console flashes if no serial console

[Zheng Bao]

It can be fixed by this change.

diff --git a/payloads/nvramcui/nvramcui.c b/payloads/nvramcui/nvramcui.c
index a4d28c1..27fcb0d6 100644
--- a/payloads/nvramcui/nvramcui.c
+++ b/payloads/nvramcui/nvramcui.c
@@ -190,16 +190,19 @@ int main()
     post_form(form);
 
     done = 0;
+    render_form(form);
     while(!done) {
-        render_form(form);
+        //render_form(form);
         ch=getch();
         if (ch == ERR) continue;
         switch (ch) {
         case KEY_DOWN:
             form_driver(form, REQ_NEXT_FIELD);
+            render_form(form);
             break;
         case KEY_UP:
             form_driver(form, REQ_PREV_FIELD);
+            render_form(form);
             break;
         case KEY_LEFT:
             if (field_type(current_field(form)) == TYPE_ENUM) {
@@ -207,6 +210,7 @@ int main()
             } else {
                 form_driver(form, REQ_LEFT_CHAR);
             }
+            render_form(form);
             break;
         case KEY_RIGHT:
             if (field_type(current_field(form)) == TYPE_ENUM) {
@@ -214,13 +218,16 @@ int main()
             } else {
                 form_driver(form, REQ_RIGHT_CHAR);
             }
+            render_form(form);
             break;
         case KEY_BACKSPACE:
         case '\b':
             form_driver(form, REQ_DEL_PREV);
+            render_form(form);
             break;
         case KEY_DC:
             form_driver(form, REQ_DEL_CHAR);
+            render_form(form);
             break;
         case KEY_F(1):
             done=1;


From: fishbaoz at hotmail.com
To: coreboot at coreboot.org
Date: Mon, 21 Mar 2016 16:55:29 +0000
Subject: [coreboot] nvramcui: VGA console flashes if no serial console




Hi, all,
I am trying to use the nvramcui.

If the serial cable is plugged in, both the serial console and VGA console are stable.
but if the serial cable is unplugged, the VGA console are flashing.  The flashing part is the text inside the frame "Press F1 when done", i.e., the CMOS entries.

Zheng
 		 	   		  

-- 
coreboot mailing list: coreboot at coreboot.org
https://www.coreboot.org/mailman/listinfo/coreboot 		 	   		  
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20160321/792e7a5c/attachment.html>