[coreboot] ARM Trusted Firmware build issue

[Martin Roth]

Hi Paul,
  Thanks for posting about this.  I've spent some time looking into
this as well, but in my usual fashion, I didn't communicate what I
found in a responsible fashion.  Here's what I posted in a code
review:


> The current binutils (2.26) is failing to build the current arm-trusted-firmware.
> This wasn't caught because the jenkins builders haven't been updated to the
> latest build tools. I tested the new release of binutils (2.26.1) and the update
> didn't help my build. There's a patch that should fix the issue - See this
> thread for an explanation of the issue and the patch:
>
> https://www.mail-archive.com/linaro-toolchain%40lists.linaro.org/msg05685.html
>
> Unfortunately, a different change went into 2.26.1 at that location, so this patch
> doesn't directly apply.

For some reason, I didn't directly test that patch with 2.26 to see if
it actually worked - I tried adding it in to 2.26.1, which did not
help.  I'll test it with 2.26 today, and add the patch into the
toolchain build if it works.

We can't roll the entire toolchain back to binutils 2.25 because of
the RISC-V work.  Is it reasonable to roll back to binutils 2.25 for
just the ARM toolchain builds?

And then I need to update the toolchains on the builders and figure
out how to keep them up-to-date so this doesn't happen again.

Sorry I didn't post this directly to the mailing list earlier.
Martin

On Wed, Jul 13, 2016 at 2:35 AM, Paul Kocialkowski <contact at paulk.fr> wrote:
> We spent some time yesterday evening on IRC investigating why the ARM Trusted
> Firmware (ATF) doesn't build with the current toolchain from coreboot's
> crossgcc.
>
> It turns out it is a complex issue on the assembler's side. I have opened a bug
> upstream about it, with all the details we could find:
> https://sourceware.org/bugzilla/show_bug.cgi?id=20364
>
> This regression was introduced with binutils 2.26. To get the build going in the
> short term, we could either downgrade binutils back to 2.25 (if it still meets
> all dependencies from other tools) or patch ATF to replace the ".align x, 0"
> directives to ".align x" in include/common/asm_macros.S (not sure this is a
> possibility).
>
> Cheers,
>
> -- Paul Kocialkowski, developer of low-level free software for embedded devices
>
> Website: https://www.paulk.fr/
> Coding blog: https://code.paulk.fr/
> Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
> --
> coreboot mailing list: coreboot at coreboot.org
> https://www.coreboot.org/mailman/listinfo/coreboot