[coreboot] Dealing with PCI reset

[Paul Menzel]

Dear coreboot folks,


Several devices using the Intel 945 chipset copied code for PCI reset,
costing 200 ms of boot time.

```
        /* Force PCIRST# */
        pci_write_config16(PCI_DEV(0, 0x1e, 0), BCTRL, SBR);
        udelay(200 * 1000);
        pci_write_config16(PCI_DEV(0, 0x1e, 0), BCTRL, 0);
```

The change-set Ia37d9f0ecf5655531616edb20b53757d5d47b42f [1] removes
that code from the Lenovo X60.

That code was added for some crypto card on a Roda device.

My question is, if removing that code is fine, or if it should be left
in and be made configurable (Kconfig/NVRAM)?

Are there often cases where there are extensions card with problems,
that need such a PCI reset?


Thanks,

Paul


[1] https://review.coreboot.org/17703
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20161211/1ea3b34c/attachment.asc>