[coreboot] Change in coreboot[master]: coreboot_table: don't add CMOS checksum twice.

[Nico Huber]

Am 16.04.2015 15:12, schrieb gerrit code review:
> From Nico Huber <nico.h at gmx.de>:
> 
> Nico Huber has posted comments on this change.
> 
> Change subject: coreboot_table: don't add CMOS checksum twice.
> ......................................................................
> 
> 
> Patch Set 3:
> 
> Ahh, took me a day to find this commit and what is going wrong.
> 
> You were right, that the checksum appeared twice in a row. But that's
> only true, if you don't read the table from the beginning: The
> checksum from the cmos_layout is nested in another tag. That makes a
> difference because libpayload parses the table, looks for the
> checksum, but doesn't understand nested tags.
> 
> I hadn't the time to check whether this problem persists upstream, but
> it looks like it does.
This still persists. To be clear: This change was meant to be cosmetic
but has real impact. Upstream, libpayload is unable to read nvram
variables since this has been merged (January 2014).

The commit still seems to be a good idea. But If nobody plans to adapt
libpayload, shall we revert it?

Nico

-- 
To view, visit http://review.coreboot.org/4829
To unsubscribe, visit http://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6d12f35fd8ff12eee9a17365bbfab38845c09574
Gerrit-PatchSet: 3
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Vladimir Serbinenko <phcoder at gmail.com>
Gerrit-Reviewer: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h at gmx.de>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: Vladimir Serbinenko <phcoder at gmail.com>
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: No

-- 
M. Sc. Nico Huber
Senior Berater SINA-Softwareentwicklung
Netzwerk- & Client-Sicherheit / Network & Client Security
Division Öffentliche Auftraggeber / Public Authorities
secunet Security Networks AG

Tel.: +49-201-5454-3635, Fax: +49-201-5454-1325
E-Mail: nico.huber at secunet.com
Mergenthalerallee 77, 65760 Eschborn, Deutschland
www.secunet.com
______________________________________________________________________

Sitz: Kronprinzenstraße 30, 45128 Essen, Deutschland
Amtsgericht Essen HRB 13615
Vorstand: Dr. Rainer Baumgart (Vors.), Thomas Pleines 
Aufsichtsratsvorsitzender: Dr. Peter Zattler
______________________________________________________________________