[coreboot] [help]build cbfstool fail with cygwin64

[Stefan Reinauer]

I think switching to c99 per default is a great idea. The problem below should be fixed by http://review.coreboot.org/#/c/11666/ and the following patch.

Stefan

On Oct 19, 2015, Julius Werner <jwerner at chromium.org> wrote:
>> is there anyway to dynamic define std to gnu99 when detect build with
>cygwin?
>
>cbfstool is already defining -std=c99. I don't see a strong reason why
>we shouldn't just change that to gnu99 globally.
>
>>>> 2. default build will error as below,
>>>> HOSTCC     cbfstool/cbfstool.o
>>>> /cygdrive/d/FW/coreboot/util/cbfstool/cbfstool.c: In function
>'main':
>>>> /cygdrive/d/FW/coreboot/util/cbfstool/cbfstool.c:1075:5: error:
>array
>>>> subscript has type 'char' [-Werror=char-subscripts]
>>>>      if (tolower(suffix[0])=='k') {
>>>>      ^
>
>This sounds like an bug in cygwin and you should file it with them.
>They're probably implementing tolower() in their standard header as a
>macro which directly indexes an array with an argument. They should at
>least be casting the argument inside that macro or they are not
>POSIX-compliant.

-- 
Sent with <a href="https://play.google.com/store/apps/details?id=com.onegravity.k10.pro2"><b>K-@ Mail</b></a> - the evolution of emailing.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20151019/009a083a/attachment-0001.html>