[coreboot] QEMU build failure in master

Aaron Durbin adurbin at google.com
Wed May 6 19:05:24 CEST 2015


On Wed, May 6, 2015 at 9:54 AM, Aaron Durbin <adurbin at google.com> wrote:
> On Wed, May 6, 2015 at 9:51 AM, Timothy Pearson
> <tpearson at raptorengineeringinc.com> wrote:
>> On 05/06/2015 11:46 AM, Aaron Durbin wrote:
>>>
>>> On Wed, May 6, 2015 at 9:45 AM, Timothy Pearson
>>> <tpearson at raptorengineeringinc.com>  wrote:
>>>>
>>>> On 05/06/2015 11:41 AM, Aaron Durbin wrote:
>>>>>
>>>>>
>>>>> That's probably my fault. I was under the impression monotonic_timer
>>>>> was a first class citizen now (I at least recall someone doing that) I
>>>>> thought wrong?
>>>>>
>>>>> You could add the following in the beginning of that function:
>>>>>
>>>>> if (!IS_ENABLED(CONFIG_HAVE_MONOTONIC_TIMER)
>>>>>      return 0;
>>>>>


This patch does make it work with your config:

diff --git a/src/lib/timestamp.c b/src/lib/timestamp.c
index 0c9c884..4b5f4d4 100644
--- a/src/lib/timestamp.c
+++ b/src/lib/timestamp.c
@@ -180,6 +180,9 @@ uint64_t  __attribute__((weak)) timestamp_get(void)
 {
        struct mono_time t1, t2;

+       if (!IS_ENABLED(CONFIG_HAVE_MONOTONIC_TIMER))
+               return 0;
+
        mono_time_set_usecs(&t1, 0);
        timer_monotonic_get(&t2);


I also confirmed it is using the implementation from
src/arch/x86/lib/timestamp.c. So I'm not sure why the original link
failed...



More information about the coreboot mailing list