[coreboot] Kconfig: Move `CBFS_SIZE` out of main section
Paul Menzel
paulepanter at users.sourceforge.net
Sat May 2 11:28:51 CEST 2015
Dear Julius, dear Peter,
thank you for your answers.
Am Freitag, den 01.05.2015, 20:30 +0200 schrieb Peter Stuge:
> Julius Werner wrote:
> > > What section should
> > >
> > > (0x400000) Size of CBFS filesystem in ROM
> > >
> > > be moved to?
> >
> > The option is closely related to ROM_SIZE, so maybe put it under
> > 'Mainboard -->' with that?
>
> Sounds good.
I pushed a change set doing just that for review [1], but it
unfortunately fails to build.
As far as I can see, the problem is, that some boards overwrite that
variable by redefining it. I guess the ordering is different in the
mainboard section now, that the default value `ROM_SIZE` is used instead
of the value defined in the mainboard directory.
src/soc/intel/baytrail/Kconfig:config CBFS_SIZE
src/soc/intel/baytrail/Kconfig- hex "Size of CBFS filesystem in ROM"
src/soc/intel/baytrail/Kconfig- default 0x100000
src/soc/intel/baytrail/Kconfig- help
src/soc/intel/baytrail/Kconfig- On Bay Trail systems the firmware image has to store a lot more
Here is an example for the GIGABYTE GA-B75M-D3H:
$ diff -u /tmp/config-master .config
--- /tmp/config-master 2015-05-02 09:47:28.438117491 +0200
+++ .config 2015-05-02 09:56:57.415420886 +0200
@@ -143,7 +143,7 @@
CONFIG_BOOT_MEDIA_SPI_BUS=0
CONFIG_TTYS0_LCS=3
CONFIG_CACHE_ROM_SIZE_OVERRIDE=0
-CONFIG_CBFS_SIZE=0x100000
+CONFIG_CBFS_SIZE=0x800000
CONFIG_POST_IO=y
CONFIG_POST_DEVICE=y
# CONFIG_HAVE_GBE_BIN is not set
[…]
How should that problem be solved in Kconfig? Remove these redefinitions
and have conditional defaults? Then they still would be hard to override
for specific boards though.
Thanks,
Paul
[1] http://review.coreboot.org/10061
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20150502/06f1f392/attachment.asc>
More information about the coreboot
mailing list