[coreboot] New Defects reported by Coverity Scan for coreboot

scan-admin at coverity.com scan-admin at coverity.com
Sat Mar 21 11:33:46 CET 2015


Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

39 new defect(s) introduced to coreboot found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 20 of 39 defect(s)


** CID 1229667:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
/src/northbridge/amd/amdk8/northbridge.c: 1083 in amdk8_domain_set_resources()


________________________________________________________________________________________________________
*** CID 1229667:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
/src/northbridge/amd/amdk8/northbridge.c: 1083 in amdk8_domain_set_resources()
1077     				pre_sizek = mmio_basek - basek;
1078     				if(pre_sizek>0) {
1079     					ram_resource(dev, (idx | i), basek, pre_sizek);
1080     					idx += 0x10;
1081     					sizek -= pre_sizek;
1082     					if (!ramtop)
>>>     CID 1229667:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "mmio_basek * 1024UL" with type "unsigned long" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "u64" (64 bits, unsigned).
1083     						ramtop = mmio_basek * 1024;
1084     				}
1085     				#if CONFIG_HW_MEM_HOLE_SIZEK != 0
1086     				if(reset_memhole)
1087     					#if !CONFIG_K8_REV_F_SUPPORT
1088     					if(!is_cpu_pre_e0() )


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/1016?tab=overview

To manage Coverity Scan email notifications for "coreboot at coreboot.org", click https://scan.coverity.com/subscriptions/edit?email=coreboot%40coreboot.org&token=49533df725f93b78361afb7b89ccde93 .




More information about the coreboot mailing list