[coreboot] New Defects reported by Coverity Scan for coreboot

scan-admin at coverity.com scan-admin at coverity.com
Tue Feb 17 21:26:23 CET 2015


Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity Scan.

8 new defect(s) introduced to coreboot found with Coverity Scan.
521 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 8 of 8 defect(s)


** CID 1270744:  Control flow issues  (NO_EFFECT)
/src/drivers/pc80/mc146818rtc.c: 270 in set_cmos_value()


________________________________________________________________________________________________________
*** CID 1270744:  Control flow issues  (NO_EFFECT)
/src/drivers/pc80/mc146818rtc.c: 270 in set_cmos_value()
264     	} else { /* more that one byte so transfer the whole bytes */
265     		if (byte_bit || length % 8)
266     			return CB_ERR_ARG;
267     
268     		for (i = 0; length; i++, length -= 8, byte++)
269     			cmos_write(ret[i], byte);
>>>     CID 1270744:  Control flow issues  (NO_EFFECT)
>>>     This greater-than-or-equal-to-zero comparison of an unsigned value is always true. "byte >= 0UL".
270     			if (byte >= LB_CKS_RANGE_START &&
271     			    byte <= LB_CKS_RANGE_END)
272     				chksum_update_needed = 1;
273     	}
274     
275     	if (chksum_update_needed) {


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit, https://scan.coverity.com/projects/1016?tab=overview

To manage Coverity Scan email notifications for "coreboot at coreboot.org", click https://scan.coverity.com/subscriptions/edit?email=coreboot%40coreboot.org&token=8ddd1fe26945626880b796e94d465567 .




More information about the coreboot mailing list