[coreboot] `cbfstool remove` leaves empty file behind

[Paul Menzel]

Dear coreboot folks,


with a coreboot image built from commit 11f1d31d (buildgcc: Deal with
gmp on 32bit Cygwin on 64bit host) [1] for the ASRock E350M1 removing
`fallback/payload` leaves an empty file behind and trying to add a file
with the same name again fails, as cbfstool says it’s already present.

    $ build/cbfstool build/coreboot.rom print
    coreboot.rom: 4096 kB, bootblocksize 1576, romsize 4194304, offset 0x0
    alignment: 64 bytes, architecture: x86

    Name                           Offset     Type         Size
    cmos_layout.bin                0x0        cmos_layout  1424
    pci1002,9802.rom.lzma          0x5c0      optionrom    33379
    fallback/dsdt.aml              0x8880     raw          9744
    fallback/romstage              0xaf00     stage        189696
    fallback/ramstage              0x39440    stage        125106
    fallback/payload               0x57d40    payload      37033
    config                         0x60e40    raw          3725
    revision                       0x61d00    raw          569
    etc/show-boot-menu             0x61f80    raw          8
    (empty)                        0x61fc0    null         3791256
    $ build/cbfstool build/coreboot.rom remove -n fallback/payload
    $ build/cbfstool build/coreboot.rom add-payload -n fallback/payload -f seabios.elf -c lzma
    E: 'fallback/payload' already in ROM image.
    $ build/cbfstool build/coreboot.rom print
    coreboot.rom: 4096 kB, bootblocksize 1576, romsize 4194304, offset 0x0
    alignment: 64 bytes, architecture: x86

    Name                           Offset     Type         Size
    cmos_layout.bin                0x0        cmos_layout  1424
    pci1002,9802.rom.lzma          0x5c0      optionrom    33379
    fallback/dsdt.aml              0x8880     raw          9744
    fallback/romstage              0xaf00     stage        189696
    fallback/ramstage              0x39440    stage        125106
    fallback/payload               0x57d40    null         37033
    config                         0x60e40    raw          3725
    revision                       0x61d00    raw          569
    etc/show-boot-menu             0x61f80    raw          8
    (empty)                        0x61fc0    null         3791256


Thanks,

Paul


[1] http://review.coreboot.org/11123
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20150807/da45de65/attachment.asc>