[coreboot] Patch merged into coreboot/master: 633f112 x86: remove stack definition in linker script

gerrit at coreboot.org gerrit at coreboot.org
Tue Mar 19 18:52:00 CET 2013

the following patch was just integrated into master:
commit 633f11274fcbc9442be0be0d0bc531f43a74981b
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Wed Feb 6 15:28:40 2013 -0600

    x86: remove stack definition in linker script
    In order to prepare the ramstage to be linked by the rmodule linker the
    stack needs to be self-contained within the ramstage objects. The
    reasoning is that the rmodule linker provides a way to define a heap,
    but it doesn't currently have a region for the stack.
    The downside to this is that memory footprint of the ramstage can change
    when compared before this change. The size difference stems from the
    link ordering of the objects as the stack is now defined within
    c_start.S. The size fluctuation ranges from 0 to CONFIG_STACK_SIZE - 1
    because of the previous behavior or aligning to CONFIG_STACK_SIZE. It
    should be noted that such an alignment is unnecessary for 32-bit x86 as
    the alignment requirement for the stacks are 4 byte alignment. Also the
    memory footprint is still dominated by CONFIG_RAMTOP and CONFIG_RAMBASE.
    Change-Id: I63a4ddd249104bc27aff2ab6b39fc6db12b54028
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/2785
    Tested-by: build bot (Jenkins)
    Reviewed-by: Marc Jones <marc.jones at se-eng.com>

Build-Tested: build bot (Jenkins) at Tue Mar 19 03:35:58 2013, giving +1
See http://review.coreboot.org/2785 for details.


More information about the coreboot mailing list