[coreboot] New patch to review for coreboot: 6fcc378 google/snow: workaround a buggy recovery mode GPIO reading

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Tue Mar 19 07:28:11 CET 2013

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2826


commit 6fcc378179b076a2899e3ba8462b17abf1c93800
Author: David Hendricks <dhendrix at chromium.org>
Date:   Mon Mar 18 23:27:09 2013 -0700

    google/snow: workaround a buggy recovery mode GPIO reading
    We don't really have a recovery mode GPIO. Instead it's fed into
    the SoC by another chip. And for whatever reason we're reading
    a weird value.
    Hard-code as a workaround.
    Change-Id: I02703e80c953d463706757c9398b6afda4941f8d
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
 src/mainboard/google/snow/chromeos.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/snow/chromeos.c b/src/mainboard/google/snow/chromeos.c
index 1a98244..6694b59 100644
--- a/src/mainboard/google/snow/chromeos.c
+++ b/src/mainboard/google/snow/chromeos.c
@@ -63,7 +63,8 @@ void fill_lb_gpios(struct lb_gpios *gpios)
 	/* Recovery: active high */
 	gpios->gpios[1].port = EXYNOS5_GPY1;
 	gpios->gpios[1].polarity = ACTIVE_HIGH;
-	gpios->gpios[1].value = s5p_gpio_get_value(&gpio_pt1->y1, FORCE_RECOVERY_MODE);
+//	gpios->gpios[1].value = s5p_gpio_get_value(&gpio_pt1->y1, FORCE_RECOVERY_MODE);
+	gpios->gpios[1].value = 0;
 	strncpy((char *)gpios->gpios[1].name,"recovery", GPIO_MAX_NAME_LENGTH);
 	/* Lid: the "switch" comes from the EC */

More information about the coreboot mailing list