[coreboot] Patch set updated for coreboot: 411eaf6 i945: Replace some two magic values by defined names

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Sat Mar 16 10:40:51 CET 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2733

-gerrit

commit 411eaf6d637f79460ca0bbddb27f247372bce0c6
Author: Patrick Georgi <patrick.georgi at secunet.com>
Date:   Fri Mar 15 14:11:37 2013 +0100

    i945: Replace some two magic values by defined names
    
    Devoutly to be wish'd. To die,—to sleep;—
    To sleep! perchance to dream:—ay, there's the rub;
    For in that sleep of death what dreams may come,
    
    (Since who could argue with William Shakespeare?)
    
    Change-Id: I4e4c617dcd3ede81a0abbe16f9916562d24fa8ce
    Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
---
 src/northbridge/intel/i945/raminit.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/northbridge/intel/i945/raminit.c b/src/northbridge/intel/i945/raminit.c
index 758a97e..bbd6528 100644
--- a/src/northbridge/intel/i945/raminit.c
+++ b/src/northbridge/intel/i945/raminit.c
@@ -295,18 +295,18 @@ static void sdram_detect_errors(struct sys_info *sysinfo)
 	pci_write_config8(PCI_DEV(0, 0x1f, 0), 0xa2, reg8);
 
 	/* clear self refresh status if check is disabled or not a resume */
-	if (!CONFIG_CHECK_SLFRCS_ON_RESUME || sysinfo->boot_path != 2) {
-		MCHBAR8(0xf14) |= 3;
+	if (!CONFIG_CHECK_SLFRCS_ON_RESUME || sysinfo->boot_path != BOOT_PATH_RESUME) {
+		MCHBAR8(SLFRCS) |= 3;
 	} else {
 		/* Validate self refresh config */
 		if (((sysinfo->dimm[0] != SYSINFO_DIMM_NOT_POPULATED) ||
 		     (sysinfo->dimm[1] != SYSINFO_DIMM_NOT_POPULATED)) &&
-		    !(MCHBAR8(0xf14) & (1<<0))) {
+		    !(MCHBAR8(SLFRCS) & (1<<0))) {
 			do_reset = 1;
 		}
 		if (((sysinfo->dimm[2] != SYSINFO_DIMM_NOT_POPULATED) ||
 		     (sysinfo->dimm[3] != SYSINFO_DIMM_NOT_POPULATED)) &&
-		    !(MCHBAR8(0xf14) & (1<<1))) {
+		    !(MCHBAR8(SLFRCS) & (1<<1))) {
 			do_reset = 1;
 		}
 	}



More information about the coreboot mailing list