[coreboot] New patch to review for coreboot: 2ae7c27 haswell: remove unused sys_info structure

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Fri Mar 15 20:50:05 CET 2013


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2753

-gerrit

commit 2ae7c276a18a7e598bfef0355065ddb4182b2ce0
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu Feb 7 00:09:59 2013 -0600

    haswell: remove unused sys_info structure
    
    This structure is not used nor the variable being instantiated on the
    stack. Remove them.
    
    Change-Id: If3abe2dd77104eff49665dd33570b07179bf34f5
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 src/northbridge/intel/haswell/raminit.c | 5 -----
 src/northbridge/intel/haswell/raminit.h | 7 -------
 2 files changed, 12 deletions(-)

diff --git a/src/northbridge/intel/haswell/raminit.c b/src/northbridge/intel/haswell/raminit.c
index e2b085b..8a38e76 100644
--- a/src/northbridge/intel/haswell/raminit.c
+++ b/src/northbridge/intel/haswell/raminit.c
@@ -147,15 +147,10 @@ static void report_memory_config(void)
  */
 void sdram_initialize(struct pei_data *pei_data)
 {
-	struct sys_info sysinfo;
 	unsigned long entry;
 
 	printk(BIOS_DEBUG, "Starting UEFI PEI System Agent\n");
 
-	memset(&sysinfo, 0, sizeof(sysinfo));
-
-	sysinfo.boot_path = pei_data->boot_mode;
-
 	/*
 	 * Do not pass MRC data in for recovery mode boot,
 	 * Always pass it in for S3 resume.
diff --git a/src/northbridge/intel/haswell/raminit.h b/src/northbridge/intel/haswell/raminit.h
index 958e983..f94dea8 100644
--- a/src/northbridge/intel/haswell/raminit.h
+++ b/src/northbridge/intel/haswell/raminit.h
@@ -22,13 +22,6 @@
 
 #include "pei_data.h"
 
-struct sys_info {
-	u8 boot_path;
-#define BOOT_PATH_NORMAL	0
-#define BOOT_PATH_RESET		1
-#define BOOT_PATH_RESUME	2
-} __attribute__ ((packed));
-
 void sdram_initialize(struct pei_data *pei_data);
 unsigned long get_top_of_ram(void);
 int fixup_haswell_errata(void);



More information about the coreboot mailing list