[coreboot] New patch to review for coreboot: 7fb9e1d ASROCK Fam14 DSDT: Remove INI method from AZHD device

Mike Loptien (mike.loptien@se-eng.com) gerrit at coreboot.org
Fri Mar 15 20:37:21 CET 2013

Mike Loptien (mike.loptien at se-eng.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2742


commit 7fb9e1de25b1dc1b9548d77dad5ad7edceae9897
Author: Mike Loptien <mike.loptien at se-eng.com>
Date:   Fri Mar 15 13:36:25 2013 -0600

    ASROCK Fam14 DSDT: Remove INI method from AZHD device
    I am removing the _INI method from the AZHD device because
    it does not seem to do anything and causes errors in the
    FWTS[1] (Firmware Test Suite) test 'method'. The INI
    method performs device specific initialization and is
    run when OSPM loads a description table.  It must only
    access OperationRegions that have been indicated as
    available by the _REG (Region) method.  We do not have a
    _REG method and during my testing, I added a REG method
    but it did not seem to make a difference in the PCI
    register space.  The bit fields defined as NSDI (Disable
    No Snoop), NSDO (Disable No Snoop Override), and NSEN
    (Enable No Snoop Request) do not ever get written from
    their default values.  And writing to these bit fields
    does not seem to be necessary because I did not notice
    any change in audio functionality.
    In an effort to clean up as many FWTS errors as possible,
    I propose removing this method altogether.  I have seen no
    change in operation (audio works with and without this
    method) and there does not seem to be any change in lspci
    or dmesg.
    FWTS information can be found here:
    [1]: https://wiki.ubuntu.com/Kernel/Reference/fwts
    This is the same chagne as made to Persimmon in
    Change-ID If8d86f:
    Change-Id: Iae70c3d0af1cdaca31b206ad6daba4d38ee6b780
    Signed-off-by: Mike Loptien <mike.loptien at se-eng.com>
 src/mainboard/asrock/e350m1/dsdt.asl | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/mainboard/asrock/e350m1/dsdt.asl b/src/mainboard/asrock/e350m1/dsdt.asl
index bc45435..1e60661 100644
--- a/src/mainboard/asrock/e350m1/dsdt.asl
+++ b/src/mainboard/asrock/e350m1/dsdt.asl
@@ -1373,14 +1373,6 @@ DefinitionBlock (
 					offset (0x6C),
 					MMDT, 16,
-				Method(_INI) {
-					If(LEqual(OSTP,3)){   /* If we are running Linux */
-						Store(zero, NSEN)
-						Store(one, NSDO)
-						Store(one, NSDI)
-					}
-				}
 			} /* end AZHD */
 			Device(LIBR) {

More information about the coreboot mailing list