[coreboot] Patch merged into coreboot/master: 50a3464 x86: SMM Module Support

gerrit at coreboot.org gerrit at coreboot.org
Thu Mar 14 05:01:52 CET 2013

the following patch was just integrated into master:
commit 50a34648cdc7fc55e1fa75d51ece608c0e27245a
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Thu Jan 3 17:38:47 2013 -0600

    x86: SMM Module Support
    Add support for SMM modules by leveraging the RMODULE lib. This allows
    for easier dynamic SMM handler placement. The SMM module support
    consists of a common stub which puts the executing CPU into protected
    mode and calls into a pre-defined handler. This stub can then be used
    for SMM relocation as well as the real SMM handler. For the relocation
    one can call back into coreboot ramstage code to perform relocation in
    C code.
    The handler is essentially a copy of smihandler.c, but it drops the TSEG
    differences. It also doesn't rely on the SMM revision as the cpu code
    should know what processor it is supported.
    Ideally the CONFIG_SMM_TSEG option could be removed once the existing
    users of that option transitioned away from tseg_relocate() and
    The generic SMI callbacks are now not marked as weak in the
    declaration so that there aren't unlinked references. The handler
    has default implementations of the generic SMI callbacks which are
    marked as weak. If an external compilation module has a strong symbol
    the linker will use that instead of the link one.
    Additionally, the parameters to the generic callbacks are dropped as
    they don't seem to be used directly. The SMM runtime can provide the
    necessary support if needed.
    Change-Id: I1e2fed71a40b2eb03197697d29e9c4b246e3b25e
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: http://review.coreboot.org/2693
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>

Build-Tested: build bot (Jenkins) at Wed Mar 13 05:05:21 2013, giving +1
Reviewed-By: Ronald G. Minnich <rminnich at gmail.com> at Thu Mar 14 05:01:50 2013, giving +2
See http://review.coreboot.org/2693 for details.


More information about the coreboot mailing list