[coreboot] New patch to review for coreboot: b473812 exynos5250/snow: call PMIC's power_init() function

David Hendricks (dhendrix@chromium.org) gerrit at coreboot.org
Wed Mar 13 05:41:07 CET 2013

David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2699


commit b4738126b180deeee0e25c5df34eb926514924ec
Author: David Hendricks <dhendrix at chromium.org>
Date:   Tue Mar 12 21:28:07 2013 -0700

    exynos5250/snow: call PMIC's power_init() function
    Call the power_init() function. We appear to have forgotten about it
    when deprecating lowlevel_init_subsystems(), but it didn't seem to
    cause problems until we got to doing more interesting stuff recently.
    There are some clean-ups to do from the original code, such as not
    attempting to configure I2C from PMIC code, which we'll get around
    to in follow-up patches.
    (Credit to Gabe for spotting this)
    Change-Id: I6a59379e9323277d0b61469de9abe6d651ac5bfb
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
    Signed-off-by: David Hendricks <dhendrix at chromium.org>
 src/cpu/samsung/exynos5250/Makefile.inc | 1 +
 src/mainboard/google/snow/romstage.c    | 7 +++++++
 2 files changed, 8 insertions(+)

diff --git a/src/cpu/samsung/exynos5250/Makefile.inc b/src/cpu/samsung/exynos5250/Makefile.inc
index 33fcedc..2774b12 100644
--- a/src/cpu/samsung/exynos5250/Makefile.inc
+++ b/src/cpu/samsung/exynos5250/Makefile.inc
@@ -17,6 +17,7 @@ romstage-y += pinmux.c  # required by s3c24x0_i2c (exynos5-common) and uart.
 romstage-y += exynos_cache.c
 romstage-y += dmc_common.c
 romstage-y += dmc_init_ddr3.c
+romstage-y += power.c
 romstage-$(CONFIG_EARLY_CONSOLE) += soc.c
 romstage-$(CONFIG_EARLY_CONSOLE) += uart.c
diff --git a/src/mainboard/google/snow/romstage.c b/src/mainboard/google/snow/romstage.c
index 83d5105..c2f5fc9 100644
--- a/src/mainboard/google/snow/romstage.c
+++ b/src/mainboard/google/snow/romstage.c
@@ -30,6 +30,7 @@
 #include <cpu/samsung/exynos5250/gpio.h>
 #include <cpu/samsung/exynos5250/setup.h>
 #include <cpu/samsung/exynos5250/periph.h>
+#include <cpu/samsung/exynos5250/power.h>
 #include <cpu/samsung/exynos5250/clock_init.h>
 #include <console/console.h>
 #include <arch/stages.h>
@@ -90,6 +91,12 @@ void main(void)
+	/*
+	 * FIXME: Do necessary I2C init so low-level PMIC code doesn't need to.
+	 * Also, we should only call power_init() on cold boot.
+	 */
+	power_init();
 	if (!mem) {
 		printk(BIOS_CRIT, "Unable to auto-detect memory timings\n");

More information about the coreboot mailing list