[coreboot] Patch merged into coreboot/master: 2c2c4fa libpayload: In the USBMSC read_capacity function, make buf an array of u32.

gerrit at coreboot.org gerrit at coreboot.org
Tue Mar 12 23:56:18 CET 2013


the following patch was just integrated into master:
commit 2c2c4fae2221f87aeff88162fa3216f3a91af793
Author: Gabe Black <gabeblack at google.com>
Date:   Tue Jan 15 16:22:04 2013 -0800

    libpayload: In the USBMSC read_capacity function, make buf an array of u32.
    
    That way when it's treated as a u32 when its value is extracted for numblocks
    and blocksize below, it doesn't make the compiler unhappy, and it ensures that
    the buffer will be properly aligned on architectures where that sort of thing
    matters.
    
    Built and saw warnings about type punning go away.
    
    Change-Id: I254e0b5e70847112d660675b7df0ac9cb52e4051
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: http://review.coreboot.org/2653
    Tested-by: build bot (Jenkins)
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>

Reviewed-By: Patrick Georgi <patrick at georgi-clan.de> at Tue Mar 12 10:19:08 2013, giving +2
Build-Tested: build bot (Jenkins) at Tue Mar 12 04:19:55 2013, giving +1
See http://review.coreboot.org/2653 for details.

-gerrit



More information about the coreboot mailing list