[coreboot] Patch merged into coreboot/master: 6e7abcd Fix 'git describe' invocation

gerrit at coreboot.org gerrit at coreboot.org
Tue Mar 12 10:22:45 CET 2013

the following patch was just integrated into master:
commit 6e7abcd4b58326dc2ea45f1523968d5a099bf6e1
Author: Vadim Bendebury <vbendeb at chromium.org>
Date:   Mon Dec 10 15:47:23 2012 -0800

    Fix 'git describe' invocation
    The 'git describe' command is used to obtain the source tree status
    information when building coreboot. As used this command expects git
    tags to be defined, so it can report the discrepancy between the
    current state of the tree and the latest tag.
    The problem is that the coreboot source tree does not have any git
    tags defined, so when 'git describe' is invoked, it reports "fatal: No
    names found, cannot describe anything.". This scary message can be
    seen on the console during coreboot builds.
    The solution is to add --always to the `git describe' invocation,
    which causes it to report the discrepancy with the latest sha1, if
    any, which is better than nothing.
      $ rm -rf /tmp/li && mkdir /tmp/li
      $ cp configs/config.link .config
      $ make obj=/tmp/li oldconfig
      $ make obj=/tmp/li
      $ grep COREBOOT_VERSION /tmp/li/build.h
      #define COREBOOT_VERSION "1623c06"
      $ echo '#' >> Makefile.inc
      $ grep COREBOOT_VERSION /tmp/li/build.h
      $ make obj=/tmp/li
      #define COREBOOT_VERSION "1623c06-dirty"
      $ git checkout Makefile.inc
    Change-Id: Ia77428b7cd765cbbd59bdbf8251b7bef489d47a5
    Signed-off-by: Vadim Bendebury <vbendeb at chromium.org>
    Reviewed-on: http://review.coreboot.org/2637
    Tested-by: build bot (Jenkins)

See http://review.coreboot.org/2637 for details.


More information about the coreboot mailing list