[coreboot] New patch to review for coreboot: c71730d src/device/root_device.c: Spew out when mainboard

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Fri Mar 8 00:30:35 CET 2013

Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2612


commit c71730d79f9e989ca3c898acb522b8d6f96917df
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Thu Mar 7 15:19:25 2013 +0100

    src/device/root_device.c: Spew out when mainboard
    For example change for ASRock E350M1
        Mainboard E350M1 Enable.
    →   Enable mainboard ASROCK E350M1
        scan_static_bus for Root Device
    Peter’s suggestion [1]: Not sure how this looks like, when dev is printed out.
    printk(BIOS_INFO "%s " CONFIG_MAINBOARD_DIR ". dev=0x%p\n", __func__, dev);
    0. Decide on level: `BIOS_INFO` or `BIOS_SPEW`?
    1. Decide on wording.
    2. Decide if `CONFIG_MAINBOARD_DIR` or `mainboard_name` should be used.
    3. Adapt all boards.
    4. Add test.
    [1] http://www.coreboot.org/pipermail/coreboot/2013-February/074621.html
    Change-Id: Ie22cfac202f6dd8060860d9600312fe5af499612
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
 src/device/root_device.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/device/root_device.c b/src/device/root_device.c
index 49fa711..f285283 100644
--- a/src/device/root_device.c
+++ b/src/device/root_device.c
@@ -136,6 +136,8 @@ static void root_dev_enable_resources(device_t dev)
 static unsigned int root_dev_scan_bus(device_t root, unsigned int max)
+	printk(BIOS_SPEW, "Enable mainboard %s\n", mainboard_name);
 	return scan_static_bus(root, max);

More information about the coreboot mailing list