[coreboot] New patch to review for coreboot: 5d9bbe7 ASRock E350M1: platform_cfg.h: Hook up Kconfig SATA Mode choice

Paul Menzel (paulepanter@users.sourceforge.net) gerrit at coreboot.org
Thu Mar 7 22:39:26 CET 2013


Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2610

-gerrit

commit 5d9bbe7ec6b88276947fd15e8a54edeaf50ed038
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date:   Sun Mar 3 10:56:15 2013 +0100

    ASRock E350M1: platform_cfg.h: Hook up Kconfig SATA Mode choice
    
    Currently despite what is chosen in Kconfig »Chipset« menu item,
    
        $ more .config
        […]
        # CONFIG_ENABLE_IDE_COMBINED_MODE is not set
        CONFIG_IDE_COMBINED_MODE=0x1
        # CONFIG_SB800_SATA_IDE is not set
        CONFIG_SB800_SATA_AHCI=y
        # CONFIG_SB800_SATA_RAID is not set
        CONFIG_SB800_SATA_MODE=0x2
        […]
    
    the SATA controller is put into IDE mode.
    
        $ lspci -nn | grep SATA
        00:11.0 SATA controller [0106]: Advanced Micro Devices [AMD] nee ATI SB7x0/SB8x0/SB9x0 SATA Controller [IDE mode] [1002:4390] (rev 40)
    
    Commit »sb800: Add sata ahci/raid mode kconfig option«
    (d4a0e7d0) [1] added the options above to configure the mode
    using Kconfig and the other SB800 boards were adapted already. For
    example commit »persimmon: sb800 sata mode configure update«
    (1386fa74) [2] did so for AMD Persimmon.
    
    Doing the same by assigning the Kconfig variable to the value in
    `platform_cfg.h` hooks this up to the ASRock E350M1 too as was
    successfully tested.
    
        $ lspci -nn | grep SATA
        00:11.0 SATA controller [0106]: Advanced Micro Devices [AMD] nee ATI SB7x0/SB8x0/SB9x0 SATA Controller [AHCI mode] [1002:4391] (rev 40)
    
    [1] http://review.coreboot.org/225
    [2] http://review.coreboot.org/227
    
    Change-Id: I227257e2c8f04f18c27ff00fe62d42e372de67e4
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
 src/mainboard/asrock/e350m1/platform_cfg.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/asrock/e350m1/platform_cfg.h b/src/mainboard/asrock/e350m1/platform_cfg.h
index 389e7db..24a66dd 100644
--- a/src/mainboard/asrock/e350m1/platform_cfg.h
+++ b/src/mainboard/asrock/e350m1/platform_cfg.h
@@ -103,7 +103,7 @@
  * @brief INCHIP Sata Controller Mode
  *   NOTE: DO NOT ALLOW SATA & IDE use same mode
  */
-#define SATA_MODE			NATIVE_IDE_MODE
+#define SATA_MODE			CONFIG_SB800_SATA_MODE
 
 /**
  * @brief INCHIP Sata IDE Controller Mode



More information about the coreboot mailing list