[coreboot] Patch merged into coreboot/master: be738eb Remove UTF-8 characters from comments

gerrit at coreboot.org gerrit at coreboot.org
Thu Mar 7 18:28:17 CET 2013


the following patch was just integrated into master:
commit be738eb1336a856bc6f2494ccd7ede3194e6c618
Author: Ronald G. Minnich <rminnich at gmail.com>
Date:   Thu Mar 7 11:05:28 2013 -0600

    Remove UTF-8 characters from comments
    
    I've used an operating system for over 10 years now that makes
    UTF-8 easy. It's not called Linux or OSX.
    
    When UTF-8 is needed, of course, then we can look again.
    I can't think of a single redeeming feature of placing
    it in the comment in this manner. It's certainy not
    needed.
    
    The inclusion of UTF-8 characters is inconvenient,
    especially from a text terminal.
    I don't really want to start using compose in
    CROSH shell terminals on chromeos.
    
    We might want to incorporate "no UTF-8" as a
    commit filter. For now, get rid of these
    characters.
    
    Change-Id: If94cc657bae1dbd282bec8de6c5309b1f8da5659
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
    Reviewed-on: http://review.coreboot.org/2604
    Reviewed-by: Bernhard Urban <lewurm at gmail.com>
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>

Build-Tested: build bot (Jenkins) at Thu Mar  7 18:19:18 2013, giving +1
See http://review.coreboot.org/2604 for details.

-gerrit



More information about the coreboot mailing list