[coreboot] New patch to review for coreboot: a7b2d85 Remove UTF-8 characters from comments

Ronald G. Minnich (rminnich@gmail.com) gerrit at coreboot.org
Thu Mar 7 18:09:44 CET 2013

Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2604


commit a7b2d85f2ebc6b3c30513502159fd51fbf6e3253
Author: Ronald G. Minnich <rminnich at gmail.com>
Date:   Thu Mar 7 11:05:28 2013 -0600

    Remove UTF-8 characters from comments
    I've used an operating system for over 10 years now that makes
    UTF-8 easy. It's not called Linux or OSX.
    When UTF-8 is needed, of course, then we can look again.
    I can't think of a single redeeming feature of placing
    it in the comment in this manner. It's certainy not
    The inclusion of UTF-8 characters is inconvenient,
    especially from a text terminal.
    I don't really want to start using compose in
    CROSH shell terminals on chromeos.
    We might want to incorporate "no UTF-8" as a
    commit filter. For now, get rid of these
    Change-Id: If94cc657bae1dbd282bec8de6c5309b1f8da5659
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
 src/arch/x86/boot/acpigen.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/arch/x86/boot/acpigen.c b/src/arch/x86/boot/acpigen.c
index 58e783e..121cb22 100644
--- a/src/arch/x86/boot/acpigen.c
+++ b/src/arch/x86/boot/acpigen.c
@@ -211,13 +211,13 @@ int acpigen_emit_namestring(const char *namepath) {
 	int dotpos = 0;
 	int len = 0;
-	/* We can start with a »\«. */
+	/* We can start with a '\'. */
 	if (namepath[0] == '\\') {
 		len += acpigen_emit_byte('\\');
-	/* And there can be any number of »^«. */
+	/* And there can be any number of '^' */
 	while (namepath[0] == '^') {
 		len += acpigen_emit_byte('^');

More information about the coreboot mailing list