[coreboot] Patch merged into coreboot/master: 069795a FrontRunner/Toucan-AF: drop unnecessary compile time CPU model selection

gerrit at coreboot.org gerrit at coreboot.org
Mon Mar 4 23:05:32 CET 2013


the following patch was just integrated into master:
commit 069795a94716cdc5d5dbeed81d491004c3e6a58e
Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
Date:   Mon Mar 4 21:13:57 2013 +0100

    FrontRunner/Toucan-AF: drop unnecessary compile time CPU model selection
    
    The first reason for selecting the CPU model at compile time was a
    multi-second pause if booting a single core Fusion T40R with MAX_CPUS=2.
    Recent tests show the pause has disappeared, someone must have fixed it.
    
    The second reason was me not knowing how to make a single vgabios image
    work with two different PCI IDs.  Many thanks to Martin Roth for educating
    me!  Quote:
    
    "The way to make coreboot use the same vbios for different video device IDs
     is through the map_oprom_vendev function. In family 14 it's in
     northbridge/amd/agesa/family14/amdfam14_conf.c You would name your video
     bios 1002,9802 in the config and all the other device/vendor IDs for the
     family 14h processors will fall through the initial check for the video
     bios and will get remapped to use that vbios. This only works if you're
     initializing the vbios inside coreboot. I don't know if you're using
     SeaBios as a payload, but if you are you can add the vbios to cbfs as
     vgaroms/vbios.rom and the rom will always be initialized."
    
    I'd like to add the vgabios is added as type 'optionrom' when Coreboot make
    adds it, however to work with SeaBios it has to be added manually with
    cbfstool and with type 'raw', or it will hang.
    
    Change-Id: I8190d0c3202a60dfccb77dde232f9ba7ce5ce318
    Signed-off-by: Jens Rottmann <JRottmann at LiPPERTembedded.de>
    Reviewed-on: http://review.coreboot.org/2584
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Mon Mar  4 22:14:28 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Mon Mar  4 22:54:13 2013, giving +2
See http://review.coreboot.org/2584 for details.

-gerrit



More information about the coreboot mailing list