[coreboot] New patch to review for coreboot: 7d364a0 libpayload: Turn on thumb interworking in libpayload.

Ronald G. Minnich (rminnich@gmail.com) gerrit at coreboot.org
Fri Mar 1 16:33:38 CET 2013


Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2567

-gerrit

commit 7d364a0ab9024c40e720bd2906725c54089d0fa7
Author: Gabe Black <gabeblack at google.com>
Date:   Fri Mar 1 03:22:22 2013 -0800

    libpayload: Turn on thumb interworking in libpayload.
    
    Things work better with it turned on, and the overhead should be negligable.
    
    Built and booted into depthcharge on Snow. Verified that calling between
    various bits of thumb and ARM code worked correctly.
    
    Change-Id: I08d1006e113d2cca08634bf19240aca138a449d9
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
---
 payloads/libpayload/util/xcompile/xcompile | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/payloads/libpayload/util/xcompile/xcompile b/payloads/libpayload/util/xcompile/xcompile
index b431d8a..62e7a38 100644
--- a/payloads/libpayload/util/xcompile/xcompile
+++ b/payloads/libpayload/util/xcompile/xcompile
@@ -109,11 +109,9 @@ detect_special_flags() {
 		arm )
 			# testcc "$CC" "$CFLAGS -mcpu=cortex-a9" &&
 			#	CFLAGS="$CFLAGS -mcpu=cortex-a9"
-			testcc "$CC" "\
-$CFLAGS -ffixed-r8 -msoft-float -marm -mabi=aapcs-linux \
--mno-thumb-interwork -march=armv7 -mno-thumb-interwork" && CFLAGS="\
-$CFLAGS -ffixed-r8 -msoft-float -marm -mabi=aapcs-linux \
--mno-thumb-interwork -march=armv7 -mno-thumb-interwork"
+			testcc "$CC" \
+"$CFLAGS -ffixed-r8 -msoft-float -marm -mabi=aapcs-linux -march=armv7" &&
+CFLAGS="$CFLAGS -ffixed-r8 -msoft-float -marm -mabi=aapcs-linux -march=armv7"
 			;;
 	esac
 }



More information about the coreboot mailing list