[coreboot] Guide lines: Prepend commit summary with component

Paul Menzel paulepanter at users.sourceforge.net
Thu Jan 31 23:24:36 CET 2013


Am Mittwoch, den 30.01.2013, 21:47 +0100 schrieb Peter Stuge:
> David Hendricks wrote:
> > If you wish to focus only on a particular part of the codebase
> 
> It's more about getting an overview of what has changed.
> 
> It is impossible to discern whether "Fix MMU setup" is at all
> relevant for my ThinkPad from the message alone. Maybe some setup
> was wrong - what do I know. "armv7: Fix MMU setup" however makes it
> clear what the change is.

Thanks Peter. That example made my point clear.

> > specify the directories/files you wish to look at when running git log.

The Web interfaces make this stuff hard.

> It's the other way around, for creating an overview.

At least I am also doing it this way. Or do Peter or I miss some trick
for getting this overview.

> The commit message represents the commit. The commit contains a root
> tree. Commits only affecting subsets of the code isn't really an
> accurate representation of how the repository works.
> 
> > Actually, I think it would look kind of ugly to do "git log src/arch/x86"
> > and see every commit cluttered with some cookie-cutter prefix.
> 
> Maybe - or maybe it is simply expected. Within x86 it's possible that
> there will be several different and distinct parts.

One other point, supporting that prepending is the right thing to do, is
that the Linux kernel is also prepending each commit summary with the
subsystem it touches.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20130131/16494aaf/attachment.sig>


More information about the coreboot mailing list