[coreboot] Patch merged into coreboot/master: d173962 cbfstool: Store global variables into struct.

gerrit at coreboot.org gerrit at coreboot.org
Mon Jan 28 19:59:41 CET 2013

the following patch was just integrated into master:
commit d173962c6e951486a7c234e269333073584b77ac
Author: Hung-Te Lin <hungte at chromium.org>
Date:   Mon Jan 28 14:23:49 2013 +0800

    cbfstool: Store global variables into struct.
    cbfstool.c uses lots of global variables for command line options and all named
    as "rom*". This may be confusing when other global variables also start with
    rom, ex:	int size = rom_size + romsize;
    (rom_size is from command line and romsize is the size of last loaded ROM image).
    If we pack all rom_* into a struct it may be more clear, ex:
    	do_something(param.cbfs_name, param.size, &romsize);
    Change-Id: I5a298f4d67e712f90e998bcb70f2a68b8c0db6ac
    Signed-off-by: Hung-Te Lin <hungte at chromium.org>
    Reviewed-on: http://review.coreboot.org/2195
    Tested-by: build bot (Jenkins)
    Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>

Build-Tested: build bot (Jenkins) at Mon Jan 28 15:27:11 2013, giving +1
Reviewed-By: Stefan Reinauer <stefan.reinauer at coreboot.org> at Mon Jan 28 19:59:40 2013, giving +2
See http://review.coreboot.org/2195 for details.


More information about the coreboot mailing list