[coreboot] Patch merged into coreboot/master: f50fbe8 AGESA: Use `Flag=AGESA_SUCCESS` instead of `TRUE` in DMI related functions

gerrit at coreboot.org gerrit at coreboot.org
Wed Jan 2 20:37:17 CET 2013

the following patch was just integrated into master:
commit f50fbe82ad0837ae7b30d7e2a5570ffc0dcc3950
Author: Aladyshev Konstantin <aladyshev at nicevt.ru>
Date:   Wed Dec 19 09:31:01 2012 +0400

    AGESA: Use `Flag=AGESA_SUCCESS` instead of `TRUE` in DMI related functions
    Success return value in DMI functions GetDmiInfoMain(..) and GetType4Type7Info(...) of AGESA vendorcode is "Flag = TRUE".
    This results in a failure of init late function:
        "agesawrapper_amdinitlate failed: 1"
    It happens because TRUE = 1 = AGESA_UNSUPPORTED.
    Replacing TRUE with AGESA_SUCCESS (= 0) fixes this problem.
    Only family f15tn does not have such bug.
    This patch just replaces TRUE with AGESA_SUCCESS, but maybe all DMI functions should be copied from Trinity family?
    Tested on Supermicro H8QGI board with 4 AMD Opteron 6234 processors (f15).
    Change-Id: I51bf91333c088a825b92d4a44d1ebe4380c8026c
    Signed-off-by: Aladyshev Konstantin <aladyshev at nicevt.ru>
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2070
    Reviewed-by: Marc Jones <marcj303 at gmail.com>
    Tested-by: build bot (Jenkins)

Build-Tested: build bot (Jenkins) at Wed Jan  2 20:35:22 2013, giving +1
Reviewed-By: Marc Jones <marcj303 at gmail.com> at Wed Jan  2 20:26:02 2013, giving +2
See http://review.coreboot.org/2070 for details.


More information about the coreboot mailing list