[coreboot] Patch merged into coreboot/master: 502533f Revert "AMD S3: Program the flash in a bigger data packet"

gerrit at coreboot.org gerrit at coreboot.org
Tue Feb 26 03:34:08 CET 2013


the following patch was just integrated into master:
commit 502533f656d41632f3b8ec19c385e8efa8c264a6
Author: Dave Frodin <dave.frodin at se-eng.com>
Date:   Mon Feb 25 10:39:48 2013 -0700

    Revert "AMD S3: Program the flash in a bigger data packet"
    
    This reverts commit ca6e1f6c04c96c435bdbf30a1b88cab0e5be330b.
    The packet size changes ends up corrupting the flash when booting
    Persimmon. I did figure out that the maximum number of bytes that
    can be sent is actually 8 bytes according to the sb800 spec. There
    must be additional problems beyond that since setting the packet
    size to 8 still causes problems.
    
    Change-Id: Ieb24247cf79e95bb0e548c83601dfddffbf6be59
    Signed-off-by: Dave Frodin <dave.frodin at se-eng.com>
    Reviewed-on: http://review.coreboot.org/2509
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martin.roth at se-eng.com>
    Reviewed-by: Zheng Bao <zheng.bao at amd.com>

Build-Tested: build bot (Jenkins) at Mon Feb 25 18:59:24 2013, giving +1
Reviewed-By: Zheng Bao <zheng.bao at amd.com> at Tue Feb 26 03:33:48 2013, giving +2
See http://review.coreboot.org/2509 for details.

-gerrit



More information about the coreboot mailing list