[coreboot] Patch set updated for coreboot: 000ab5c mainboard.c: Name enable_dev function uniformly `mainboard_enable`

Peter Stuge peter at stuge.se
Mon Feb 25 21:18:30 CET 2013


Paul Menzel wrote:
> +++ b/src/mainboard/aaeon/pfm-540i_revb/mainboard.c
> @@ -26,11 +26,11 @@ static void init(struct device *dev)
>  	printk(BIOS_DEBUG, "AAEON PFM-540I_REVB EXIT %s\n", __func__);

Next step: Replace all explicit strings like the above with vendor
and board names in Kconfig.


> +++ b/src/mainboard/advansus/a785e-i/mainboard.c
> @@ -73,7 +73,7 @@ u8 is_dev3_present(void)
>  * enable the dedicated function in A785E-I board.
>  * This function called early than rs780_enable.
>  *************************************************/
> -static void a785e_i_enable(device_t dev)
> +static void mainboard_enable(device_t dev)
>  {
>  	printk(BIOS_INFO, "Mainboard A785E-I Enable. dev=0x%p\n", dev);

And here too.

printk(BIOS_INFO "%s " CONFIG_MAINBOARD_DIR ". dev=0x%p\n", __func__, dev);

Those changes should be accompanied with a test that FAILs if
"mainboard" and "enable" are in the same string in mainboard.c.


//Peter



More information about the coreboot mailing list