[coreboot] Patch merged into coreboot/master: 940095f AMD based boards: platform_cfg.h: Replace `_*BOARDNAME*_CFG_H_` with `_PLATFORM_CFG_H_`

gerrit at coreboot.org gerrit at coreboot.org
Sat Feb 23 01:22:30 CET 2013

the following patch was just integrated into master:
commit 940095fe5e4181f1708ff2298f17f7056b8e18ff
Author: Jens Rottmann <JRottmann at LiPPERTembedded.de>
Date:   Wed Feb 20 21:24:20 2013 +0100

    AMD based boards: platform_cfg.h: Replace `_*BOARDNAME*_CFG_H_` with `_PLATFORM_CFG_H_`
    Reduce unnecessary differences between AMD based boards only
    using the file `platform_cfg.h` for configuration making them
    a little bit easier to compare.
    Inagua & co. mention the board name in several places which are really not
    that board specific.  Sometimes people even forget to change it:
    Union Station’s platform_cfg.h starts with "#ifndef _PERSIMMON_CFG_H_".
    Funny.  Change that to "_PLATFORM_CFG_H_" everywhere.
    The following command was used.
        $ find . -name platform_cfg.h | xargs sed -i '/_CFG_H_/s/_.*_/_PLATFORM_CFG_H_/'
    More boards seem to use that kind of naming (`git grep _CFG_H_`)
    but it is not certain that this will not break anything as for
    example the board AMD Dinar also has header files for
    configuration stuff for the north- and southbridge.
        $ git grep _CFG_H_
        src/mainboard/amd/dinar/platform_cfg.h:#ifndef _PLATFORM_CFG_H_
        src/mainboard/amd/dinar/platform_cfg.h:#define _PLATFORM_CFG_H_
        src/mainboard/amd/dinar/platform_cfg.h:#endif //_PLATFORM_CFG_H_
        src/mainboard/amd/dinar/rd890_cfg.h:#ifndef  _RD890_CFG_H_
        src/mainboard/amd/dinar/rd890_cfg.h:#define _RD890_CFG_H_
        src/mainboard/amd/dinar/rd890_cfg.h:#endif //_RD890_CFG_H_
        src/mainboard/amd/dinar/sb700_cfg.h:#ifndef _SB700_CFG_H_
        src/mainboard/amd/dinar/sb700_cfg.h:#define _SB700_CFG_H_
        src/mainboard/amd/dinar/sb700_cfg.h:#endif //_SB700_CFG_H
    Change-Id: Ida15fa6a7adfc770240ac30e795946000dae3f16
    Signed-off-by: Jens Rottmann <JRottmann at LiPPERTembedded.de>
    Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-on: http://review.coreboot.org/2464
    Tested-by: build bot (Jenkins)
    Reviewed-by: Martin Roth <martin.roth at se-eng.com>

Build-Tested: build bot (Jenkins) at Fri Feb 22 13:58:42 2013, giving +1
See http://review.coreboot.org/2464 for details.


More information about the coreboot mailing list