[coreboot] New patch to review for coreboot: 6a83bf3 RMV7: create a correct LB_SERIAL table entry

Ronald G. Minnich (rminnich@gmail.com) gerrit at coreboot.org
Wed Feb 20 23:14:52 CET 2013

Ronald G. Minnich (rminnich at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/2466


commit 6a83bf3f1b2ca4c8caa451b79f45c1cb81684e64
Author: Ronald G. Minnich <rminnich at gmail.com>
Date:   Wed Feb 20 14:13:01 2013 -0800

    RMV7: create a correct LB_SERIAL table entry
    If CONFIG_CONSOLE_SERIAL is set, and we can call the standard function
    and get a non-zero uart address, then we create an lb table entry.
    The code was mostly right, just needed a tweak.
    Change-Id: I5b36c7b4e580a23319b7ba92cc8ad61592b1757a
    Signed-off-by: Ronald G. Minnich <rminnich at gmail.com>
 src/arch/armv7/boot/coreboot_table.c | 13 +------------
 1 file changed, 1 insertion(+), 12 deletions(-)

diff --git a/src/arch/armv7/boot/coreboot_table.c b/src/arch/armv7/boot/coreboot_table.c
index 044f3d5..2810a5e 100644
--- a/src/arch/armv7/boot/coreboot_table.c
+++ b/src/arch/armv7/boot/coreboot_table.c
@@ -110,18 +110,7 @@ static struct lb_memory *lb_memory(struct lb_header *header)
 static struct lb_serial *lb_serial(struct lb_header *header)
-	struct lb_record *rec;
-	struct lb_serial *serial;
-	rec = lb_new_record(header);
-	serial = (struct lb_serial *)rec;
-	serial->tag = LB_TAG_SERIAL;
-	serial->size = sizeof(*serial);
-	serial->type = LB_SERIAL_TYPE_IO_MAPPED;
-	serial->baseaddr = CONFIG_TTYS0_BASE;
-	serial->baud = CONFIG_TTYS0_BAUD;
-	return serial;
 	if (uartmem_getbaseaddr()) {
 		struct lb_record *rec;
 		struct lb_serial *serial;

More information about the coreboot mailing list